tboudreaux/SERiF
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(Metadata): byteSize_ changed from std::size_t to int to avoid implicit type conversion

Browse Source
This commit is contained in:
Emily Boudreaux
2025-01-22 06:50:02 -05:00
parent d331645c88
commit 3b9cd3726d
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/dobj/public/Metadata.h
View File

@@ -103,7 +103,7 @@ public:
friend std::ostream& operator<<(std::ostream& os, const Metadata& metadata);
private:
std::size_t byteSize_ = 0; ///< Total size of the data in bytes.
int byteSize_ = 0; ///< Total size of the data in bytes.
std::string dataType_; ///< Type of the data (e.g., "float", "double").
std::vector<std::size_t> dimensions_; ///< Dimensions of the data (e.g., {3, 4} for a 3x4 matrix).
bool debugFlag_ = false; ///< Indicates whether debugging is enabled.

7
tests/dobj/MetadataTest.cpp
View File

@@ -27,7 +27,9 @@ protected:
TEST_F(MetadataTest, DefaultConstructor) {
Metadata metadata;
EXPECT_EQ(metadata.getByteSize(), 0);
int expectedByteSize = 0;
EXPECT_EQ(metadata.getByteSize(), expectedByteSize);
EXPECT_EQ(metadata.getDataType(), "");
EXPECT_TRUE(metadata.getDimensions().empty());
EXPECT_FALSE(metadata.isDebugEnabled());
@@ -40,7 +42,8 @@ TEST_F(MetadataTest, ParameterizedConstructor) {
std::vector<std::size_t> dimensions = {3, 4, 5};
Metadata metadata(120, "float", dimensions, true);
EXPECT_EQ(metadata.getByteSize(), 120);
int expectedByteSize = 120;
EXPECT_EQ(metadata.getByteSize(), expectedByteSize);
EXPECT_EQ(metadata.getDataType(), "float");
EXPECT_EQ(metadata.getDimensions(), dimensions);
EXPECT_TRUE(metadata.isDebugEnabled());