From 3b9cd3726d7923282adfac78caaafab395ee7ad6 Mon Sep 17 00:00:00 2001 From: Emily Boudreaux Date: Wed, 22 Jan 2025 06:50:02 -0500 Subject: [PATCH] fix(Metadata): byteSize_ changed from std::size_t to int to avoid implicit type conversion --- src/dobj/public/Metadata.h | 2 +- tests/dobj/MetadataTest.cpp | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/dobj/public/Metadata.h b/src/dobj/public/Metadata.h index 5811fc5..11696ad 100644 --- a/src/dobj/public/Metadata.h +++ b/src/dobj/public/Metadata.h @@ -103,7 +103,7 @@ public: friend std::ostream& operator<<(std::ostream& os, const Metadata& metadata); private: - std::size_t byteSize_ = 0; ///< Total size of the data in bytes. + int byteSize_ = 0; ///< Total size of the data in bytes. std::string dataType_; ///< Type of the data (e.g., "float", "double"). std::vector dimensions_; ///< Dimensions of the data (e.g., {3, 4} for a 3x4 matrix). bool debugFlag_ = false; ///< Indicates whether debugging is enabled. diff --git a/tests/dobj/MetadataTest.cpp b/tests/dobj/MetadataTest.cpp index 7e5936f..d770a68 100644 --- a/tests/dobj/MetadataTest.cpp +++ b/tests/dobj/MetadataTest.cpp @@ -27,7 +27,9 @@ protected: TEST_F(MetadataTest, DefaultConstructor) { Metadata metadata; - EXPECT_EQ(metadata.getByteSize(), 0); + int expectedByteSize = 0; + + EXPECT_EQ(metadata.getByteSize(), expectedByteSize); EXPECT_EQ(metadata.getDataType(), ""); EXPECT_TRUE(metadata.getDimensions().empty()); EXPECT_FALSE(metadata.isDebugEnabled()); @@ -40,7 +42,8 @@ TEST_F(MetadataTest, ParameterizedConstructor) { std::vector dimensions = {3, 4, 5}; Metadata metadata(120, "float", dimensions, true); - EXPECT_EQ(metadata.getByteSize(), 120); + int expectedByteSize = 120; + EXPECT_EQ(metadata.getByteSize(), expectedByteSize); EXPECT_EQ(metadata.getDataType(), "float"); EXPECT_EQ(metadata.getDimensions(), dimensions); EXPECT_TRUE(metadata.isDebugEnabled());