1.6 KiB
Gravity work accounting on direction rejection
The combined polynomial-enthalpy and reduced-gravity strategy checks descent twice: once when selecting the enthalpy repair, and again after lifting the repaired retained direction into gravity coordinates. A successful gravity relift performs real auxiliary work even when the second check rejects the direction before line search.
Previously, the successful-relift diagnostics were copied only after the second check. Its early rejection could therefore leave solve counts, iteration counts, timings, and the last inner residual at their earlier linear-solve snapshot. The snapshot now occurs immediately after successful direction capture and before the final descent check. Linear-report coordinates retain their existing meaning; this changes no tolerance, direction, state, or acceptance decision.
The immutable b21fa40 rotating positivity-reduced artifact records 20 gravity
solves and a positive final merit slope. Those counters can omit a successful
last relift: they do not distinguish rejection during enthalpy repair from
rejection after relifting. Its direction_repairs count also includes a chosen
positive repair fraction whose candidate subsequently fails descent. Historical
artifacts must retain these qualifications rather than being retroactively
interpreted as complete work counters.
The regression is a repeat of that bounded combined rotating case, checking unchanged accepted states and residual history while accounting for all successful relift work. No extra numerical fixture or solver change is needed.