From 324602226c370610415d5a8f129137c6fe74ab1d Mon Sep 17 00:00:00 2001 From: Aaron Dotter Date: Thu, 12 Jun 2025 16:46:33 -0400 Subject: [PATCH 1/3] Update helm.cpp fix bug allowing integer iat to be used before being set. two lines of code were swapped to fix the problem. --- src/eos/private/helm.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/eos/private/helm.cpp b/src/eos/private/helm.cpp index efed85f..99c8cdb 100644 --- a/src/eos/private/helm.cpp +++ b/src/eos/private/helm.cpp @@ -355,8 +355,8 @@ namespace serif::eos::helmholtz { // hash the table location in t, rho: jat = (log10(T) - tlo)*tstpi; jat = max(0, min(jat, table.jmax-1)); // bounds - iat = max(0, min(iat, table.imax-1)); // bounds iat = (log10(din)-dlo)*dstpi; + iat = max(0, min(iat, table.imax-1)); // bounds //using the indices, access the table: fi[0] = table.f[iat][jat]; From 96de8cf6ccf605372b1eca66e283eb3d22664c7f Mon Sep 17 00:00:00 2001 From: Emily Boudreaux Date: Thu, 12 Jun 2025 17:02:15 -0400 Subject: [PATCH 2/3] fix(qhull.wrap): removed bad qhull.wrap file qhull.wrap should never have ended up in the git repo --- subprojects/qhull.wrap | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 subprojects/qhull.wrap diff --git a/subprojects/qhull.wrap b/subprojects/qhull.wrap deleted file mode 100644 index 3d31585..0000000 --- a/subprojects/qhull.wrap +++ /dev/null @@ -1,2 +0,0 @@ -[wrap-redirect] -filename = opat-core/subprojects/qhull.wrap From 7daf32119d4125382056951afeacfb8f0e8a67eb Mon Sep 17 00:00:00 2001 From: Emily Boudreaux Date: Thu, 12 Jun 2025 17:03:02 -0400 Subject: [PATCH 3/3] refactor(.gitignore): added qhull.wrap to prevent it from being added again --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 3f58435..ab5ee4d 100644 --- a/.gitignore +++ b/.gitignore @@ -69,6 +69,8 @@ subprojects/packagecache/ subprojects/hypre/ subprojects/qhull/ +qhull.wrap + .vscode/ *.log