From 513e90b7a076c12504e81e12d08036cbf38b4c1b Mon Sep 17 00:00:00 2001 From: Emily Boudreaux Date: Mon, 21 Apr 2025 09:05:34 -0400 Subject: [PATCH] refactor(solver): renamed setupOperator -> setOperatorEssentialTrueDofs to better reflect method job --- src/poly/solver/private/polySolver.cpp | 8 ++++---- src/poly/solver/public/polySolver.h | 2 +- src/poly/utils/private/operator.cpp | 2 -- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/poly/solver/private/polySolver.cpp b/src/poly/solver/private/polySolver.cpp index 6073368..96da470 100644 --- a/src/poly/solver/private/polySolver.cpp +++ b/src/poly/solver/private/polySolver.cpp @@ -178,13 +178,13 @@ void PolySolver::solve() const { // --- Set the initial guess for the solution --- setInitialGuess(); - setupOperator(); + setOperatorEssentialTrueDofs(); // It's safer to get the offsets directly from the operator after finalization const mfem::Array& block_offsets = m_polytropOperator->GetBlockOffsets(); // Assuming a getter exists or accessing member if public/friend mfem::BlockVector state_vector(block_offsets); - state_vector.GetBlock(0) = static_cast(*m_theta); - state_vector.GetBlock(1) = static_cast(*m_phi); + state_vector.GetBlock(0) = static_cast(*m_theta); // NOLINT(*-slicing) + state_vector.GetBlock(1) = static_cast(*m_phi); // NOLINT(*-slicing) mfem::Vector zero_rhs(block_offsets.Last()); zero_rhs = 0.0; @@ -304,7 +304,7 @@ void PolySolver::saveAndViewSolution(const mfem::BlockVector& state_vector) cons } } -void PolySolver::setupOperator() const { +void PolySolver::setOperatorEssentialTrueDofs() const { SSE::MFEMArrayPairSet ess_tdof_pair_set = getEssentialTrueDof(); m_polytropOperator->SetEssentialTrueDofs(ess_tdof_pair_set); diff --git a/src/poly/solver/public/polySolver.h b/src/poly/solver/public/polySolver.h index c1ea209..ecc1597 100644 --- a/src/poly/solver/public/polySolver.h +++ b/src/poly/solver/public/polySolver.h @@ -84,7 +84,7 @@ private: // Private methods void setInitialGuess() const; void saveAndViewSolution(const mfem::BlockVector& state_vector) const; solverBundle setupNewtonSolver() const; - void setupOperator() const; + void setOperatorEssentialTrueDofs() const; void LoadSolverUserParams(double &newtonRelTol, double &newtonAbsTol, int &newtonMaxIter, int &newtonPrintLevel, double &gmresRelTol, double &gmresAbsTol, int &gmresMaxIter, int &gmresPrintLevel) const; diff --git a/src/poly/utils/private/operator.cpp b/src/poly/utils/private/operator.cpp index 3709dcd..ca70062 100644 --- a/src/poly/utils/private/operator.cpp +++ b/src/poly/utils/private/operator.cpp @@ -286,8 +286,6 @@ void PolytropeOperator::SetEssentialTrueDofs(const SSE::MFEMArrayPair& theta_ess if (m_f) { m_f->SetEssentialTrueDofs(theta_ess_tdofs.first); - - // This should be zeroing out the row; however, I am getting a segfault } else { MFEM_ABORT("m_f is null in PolytropeOperator::SetEssentialTrueDofs"); }