fix(engine_multiscale): resolved a major species index ordering bug
All jacobian calculations were broken because the indexing used to record the AD tape was broken (see not parallel to) the indexing used by the composition object. A fix for this was to sort the network species by mass. However, more generally we should introduce a mechanism to ensure these two indexed sets always remain parallel
This commit is contained in:
@@ -144,6 +144,8 @@ namespace gridfire::solver {
|
||||
const auto relTol = m_config.get<double>("gridfire:solver:CVODESolverStrategy:relTol", 1.0e-8);
|
||||
|
||||
fourdst::composition::Composition equilibratedComposition = m_engine.update(netIn);
|
||||
std::cout << "EXITED AT EXPECTED TESTING POINT" << std::endl;
|
||||
exit(0);
|
||||
|
||||
size_t numSpecies = m_engine.getNetworkSpecies().size();
|
||||
uint64_t N = numSpecies + 1;
|
||||
|
||||
Reference in New Issue
Block a user