fix(engine_multiscale): resolved a major species index ordering bug
All jacobian calculations were broken because the indexing used to record the AD tape was broken (see not parallel to) the indexing used by the composition object. A fix for this was to sort the network species by mass. However, more generally we should introduce a mechanism to ensure these two indexed sets always remain parallel
This commit is contained in:
@@ -28,6 +28,18 @@ namespace gridfire::reaction {
|
||||
REACLIB,
|
||||
LOGICAL_REACLIB,
|
||||
};
|
||||
|
||||
static std::unordered_map<ReactionType, std::string> ReactionTypeNames = {
|
||||
{ReactionType::WEAK, "weak"},
|
||||
{ReactionType::REACLIB, "reaclib"},
|
||||
{ReactionType::LOGICAL_REACLIB, "logical_reaclib"},
|
||||
};
|
||||
|
||||
static std::unordered_map<ReactionType, std::string> ReactionPhysicalTypeNames = {
|
||||
{ReactionType::WEAK, "Weak"},
|
||||
{ReactionType::REACLIB, "Strong"},
|
||||
{ReactionType::LOGICAL_REACLIB, "Strong"},
|
||||
};
|
||||
/**
|
||||
* @struct RateCoefficientSet
|
||||
* @brief Holds the seven coefficients for the REACLIB rate equation.
|
||||
|
||||
Reference in New Issue
Block a user